Skip to content

feat: remember last results view in localStorage#3432

Open
Chartman123 wants to merge 2 commits into
mainfrom
feat/remember-result-view
Open

feat: remember last results view in localStorage#3432
Chartman123 wants to merge 2 commits into
mainfrom
feat/remember-result-view

Conversation

@Chartman123

@Chartman123 Chartman123 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This implements #483 by storing the last used results view to localStorage. Values are stored per form per user, values for forms that are no longer available to the user will be removed upon loading forms.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Chartman123 Chartman123 added this to the 5.4 milestone Jun 17, 2026
@Chartman123 Chartman123 self-assigned this Jun 17, 2026
@Chartman123 Chartman123 changed the title feat: implement localStorage management for results view feat: remember last results view in localStorage Jun 18, 2026

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! All works correctly, either when refreshing the page, or navigating between the different View/Edit/Results tabs.

One detail:
The focus is initially always on "Summary", so there is a brief flash of blue over there until it switches to "Responses". Is it possible to have an "indeterminate" state so that until we know which one is selected, none will be visually highlighted?

@jancborchardt

Copy link
Copy Markdown
Member

And alternatively – @Chartman123 does it make sense to also add this part of the path at the end of the URL? Then you can specifically bookmark it too, for opening on other devices.

@Chartman123

Copy link
Copy Markdown
Collaborator Author

And alternatively – @Chartman123 does it make sense to also add this part of the path at the end of the URL? Then you can specifically bookmark it too, for opening on other devices.

Yes, that's what I already thought about too :)

Is it possible to have an "indeterminate" state so that until we know which one is selected, none will be visually highlighted?

I'll have another look at it.

Thanks for the review! 👍🏻

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the feat/remember-result-view branch from 5d4363c to 159ee58 Compare June 23, 2026 14:34
@Chartman123

Copy link
Copy Markdown
Collaborator Author

@jancborchardt updated the code so that the current results view is also reflected in a query param (?summary or ?responses)

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the feat/remember-result-view branch from 159ee58 to 6761911 Compare June 23, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants